search

GoogleChrome / accessibility-developer-tools

This is a library of accessibility-related testing and utility code.
Apache License 2.0
2.27k stars 359 forks source link

The js library reports only a subset of accessibility errors/ warnings #331

Closed prashant4github closed 7 years ago

prashant4github commented 7 years ago

Hi, I tried to utilize the accessibility JS library (https://raw.github.com/GoogleChrome/accessibility-developer-tools/stable/dist/js/axs_testing.js) to check my webpage for "accessibility errors". The js library did work but returned a limited number of error/ warning details in comparison to errors reported by "Accessibility developer tool plugin for Chrome browser". I assume, this happened because the online JS library (https://raw.github.com/GoogleChrome/accessibility-developer-tools/stable/dist/js/axs_testing.js) is not up to date. Can an up to date version of this js libraray be provided to us? Please let me know. Thanks, Prashant

schindld commented 7 years ago

If you diff v2.11.0 and v2.12.0, you will see that almost 20 rules were removed at the end of the file. You can copy/paste them back in, and it will work - running all 28 rules for you. No idea why the rules were removed though.

jbanks77 commented 7 years ago

Wow, thank you, my nephew was playing his game on my laptop, maybe I left it exposed, I’m sry

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: schindldmailto:notifications@github.com Sent: Tuesday, April 4, 2017 10:55 AM To: GoogleChrome/accessibility-developer-toolsmailto:accessibility-developer-tools@noreply.github.com Cc: Subscribedmailto:subscribed@noreply.github.com Subject: Re: [GoogleChrome/accessibility-developer-tools] The js library reports only a subset of accessibility errors/ warnings (#331)

If you diff v2.11.0https://raw.githubusercontent.com/GoogleChrome/accessibility-developer-tools/v2.11.0/dist/js/axs_testing.js and v2.12.0https://raw.githubusercontent.com/GoogleChrome/accessibility-developer-tools/v2.12.0/dist/js/axs_testing.js, you will see that almost 20 rules were removed at the end of the file. You can copy/paste them back in, and it will work - running all 28 rules for you. No idea why the rules were removed though.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/GoogleChrome/accessibility-developer-tools/issues/331#issuecomment-291526000, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ATDrDokPl4dbR0rYODSwGRqaYjiT0ZZPks5rslnogaJpZM4LY82O.

schindld commented 7 years ago

@jbanks77 you might want to delete your comment, as it seems you didn't realize you were posting in this thread: https://github.com/GoogleChrome/accessibility-developer-tools/issues/331.

@prashant4github, just use v2.11.0 for now, until v2.12.0 becomes stable.

prashant4github commented 7 years ago

@schindld Thanks for the update. I will use v2.11.0 for now. :)