GoogleChrome / accessibility-developer-tools

This is a library of accessibility-related testing and utility code.
Apache License 2.0
2.28k stars 363 forks source link

Fix axs.utils.isLargeFont float issue (#345) #346

Open timmhayes opened 7 years ago

timmhayes commented 7 years ago

This fix should allow the isLargeFont function to correctly evaluate font sizes with decimals.

As it is now, a font sizes of 10pt can be evaluated as a large font because Chrome returns it as having a size of 13.333px, which the RegEx returns as 3333.

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


timmhayes commented 7 years ago

I signed the CLA

googlebot commented 7 years ago

CLAs look good, thanks!