search

GoogleChrome / accessibility-developer-tools

This is a library of accessibility-related testing and utility code.
Apache License 2.0
2.28k stars 362 forks source link

How to compile a axs_testing.js that contains all tests? #347

Open BarisW opened 7 years ago

BarisW commented 7 years ago

Hi all!

I just found out about this repo. Great stuff! I'm trying to implement it in our Jenkins environment, using phantomjs, and it kind-of works. However, the bundled axs_testing.js only contains a few tests, and I would love to implement more tests. For example, it doesn't test for contrast or a missing <title> element. How can I tell grunt which tests to include when re-compiling axs_testing.js?

Thanks for the help!

BarisW commented 7 years ago

To clarify my issue: the hosted axs_testing.js version seems to contain all tests: https://raw.githubusercontent.com/GoogleChrome/accessibility-developer-tools/stable/dist/js/axs_testing.js

In this file, I can see for example the focusableElementNotVisibleAndNotAriaHidden test. In the axs_testing.js in the repo (/dist/js/axs_testing.js) this test is missing - and a lot of other tests. If I re-compile a new axs_testing.js using grunt, this test is also missing. Although the closure-compiler in the Gruntfile.js seems to include all /src/audits/*.

What am I missing?

BarisW commented 7 years ago

I'm getting warmer to the actual problem. The axs_testing.js file pointed out on the README.md (https://raw.github.com/GoogleChrome/accessibility-developer-tools/stable/dist/js/axs_testing.js) is a file generated on a codebase from 2014 (http://github.com/GoogleChrome/accessibility-developer-tools/tree/3d4893b4ecd0eb8f4765e04479213d04b240f3e0), the stable build.

However, the axs_testing.js included in the git clone is way newer and misses a lot of tests, although these tests are still available in the src folder. Why are they not longer included in the axs_testing.js?

Is this a bug in the closure-compiler?

srm985 commented 6 years ago

@BarisW did you ever uncover a solution to this issue? When I build the project and run it, it seems to not catch much. I'm not sure if I'm just missing something or if it's still not functioning correctly. I tried to run the script linked in your second post but it requested some additional parameters for which I haven't previously been prompted.

valdrinkoshi commented 6 years ago

Looks related to https://github.com/GoogleChrome/accessibility-developer-tools/issues/356. You can point to a specific version like this https://raw.githubusercontent.com/GoogleChrome/accessibility-developer-tools/v2.11.0/dist/js/axs_testing.js (2.11.0 seems to have all the tests included)