search

GoogleChrome / android-browser-helper

The Android Browser Helper library helps developers use Custom Tabs and Trusted Web Activities on top of the AndroidX browser support library.
Apache License 2.0
688 stars 286 forks source link

Adapt caching behaviour for dark/light theme switching #463

Open khmyznikov opened 6 months ago

khmyznikov commented 6 months ago

Trying to address this bug

khmyznikov commented 6 months ago

@uwolfer is it looks like a fix?

khmyznikov commented 6 months ago

@PEConn @andreban how to check build?

khmyznikov commented 6 months ago

@andreban from my understanding, it solves the issue of wrong caching of different icons for light/dark splash screen. https://github.com/GoogleChrome/android-browser-helper/pull/51#issuecomment-1978621933

andreban commented 6 months ago

Thanks for the update! What I'm making sure I understand is how this PR solves the issue - my understanding is that the bug is caused by only re-transferring the splash image file when the application is updated. But it also needs to be transferred when the theme changes. To solve that, you're adding the theme to the default preferences object, retrieving the value on launch, and ensuring the existing file is only re-used if all the following are true: the file exists, the app hasn't been updated, and the theme wasn't change. Does this sound right?

khmyznikov commented 6 months ago

@andreban yeah that's sounds right 👍

uwolfer commented 6 months ago

@uwolfer is it looks like a fix?

Thanks for working on this, @khmyznikov. Code makes sense to me, but I have not tested it. I would suggest that you update the PR title to reflect what we actually have fixed with this change.