GoogleChrome / chrome-launcher

Launch Google Chrome with ease from node.
https://www.npmjs.com/package/chrome-launcher
Apache License 2.0
1.26k stars 189 forks source link

Feature: add support for Chrome Dev Channel #318

Closed ahmadalfy closed 1 year ago

ahmadalfy commented 1 year ago

I am using Chrome Dev Channel and the script fails to identify it. I came to this repository from lighthouse. I believe adding the dev channel would be essential.

I maintained the priority by inserting the dev channel between canary and stable.

paulirish commented 1 year ago

The chromefinder stuff is kinda slow so I'm hesitant to add in a devchannel lookup.

You can set CHROME_PATH env var to point wherever you want. so.. i'd suggest that. sorry. :/

ahmadalfy commented 1 year ago

You can set CHROME_PATH env var to point wherever you want. so.. i'd suggest that. sorry. :/

No problem, can I ask about the path that should be set? I am currently on Mac so when I set it to be the package itself (e.g /Applications/Google Chrome Dev.app) it fails to start. Or it should be the executable path? /Applications/Google Chrome Dev.app/Contents/MacOS/Google Chrome Dev

Side note, I was happy to read your name on the email notification. 10 years ago I enjoyed your podcasts, contribution and everything you were doing. I really miss those days 🤗

paulirish commented 1 year ago

No problem, can I ask about the path that should be set? I am currently on Mac so when I set it to be the package itself (e.g /Applications/Google Chrome Dev.app) it fails to start. Or it should be the executable path? /Applications/Google Chrome Dev.app/Contents/MacOS/Google Chrome Dev

CHROME_PATH="/Applications/Google Chrome Dev.app/Contents/MacOS/Google Chrome Dev" exactly. you nailed it.

Side note, I was happy to read your name on the email notification. 10 years ago I enjoyed your podcasts, contribution and everything you were doing. I really miss those days 🤗

aw thanks. i miss those days too, dude. :) cheers.