Closed oliverdunk closed 1 year ago
Base: 35.47% // Head: 35.60% // Increases project coverage by +0.13%
:tada:
Coverage data is based on head (
13b4a32
) compared to base (8ba5062
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
To test this, I ran the tool with and without this change and compared the output. The changes looked as expected:
chrome.action.setTitle
) the version tag is skipped.I also compared version numbers with a number of CLs/commits and found them to be accurate.
Prior to this change return values defined using the returns_async keyword did not properly appear in the history. This is because returns_async was not considered when creating the list of expansions.
Once this was added, there was a second issue because the old void/callback expansion was seen after the promise-based one and overwrote the history data we had generated. To avoid this I added logic which always prefers a return type over void.
Resolves #35