GoogleChrome / chromium-dashboard

Chrome Status Dashboard
https://www.chromestatus.com
Apache License 2.0
635 stars 363 forks source link

Deprecations and removals need separate milestones #1491

Open jpmedley opened 3 years ago

jpmedley commented 3 years ago

Thank you for letting us know that something needs to be fixed. This page is for recording bugs on Chrome Status (https://www.chromestatus.com). If you need to report a problem with Chrome or Chromium, please use crbug (http://crbug.com/new). Thank you.

Describe the bug The full sequence for deprecation is this (optional items in parentheses):

(Dev Trial) > (reverse origin trial) > ship deprecation > ship removal

In other words there are two ship stages for deprecations removals. The Chrome status wizard only provides one. Currently a shipping deprecation shows up on the rendered card as "Removed"

image

Expected behavior The wizard needs to provide two shipping stages for deps/rems. This probably need separate data fields for both stages.

Additional context The shipped deprecation stage isn one that includes code to write a deprecation warning to the DevTools console and pass it to a reporting API end point.

jpmedley commented 3 years ago

cc: @PaulKinlan

jpmedley commented 2 years ago

A related ticket for a deprecation/removal was marked fixed this week (even though the removal was shipped in 89).

As stated above, the deprecation was technically an enabled state. This is shown in the image below. To update this ticket to show removal, I must effectively remove the earlier information.

image

jpmedley commented 2 years ago

Here's another example of the kind of mess we have now. What it shows is that the owner of this feature didn't know to create a new status entry.

image

domenic commented 2 years ago

I think this is the issue @natechapin and I have, so I will state our case here. Apologies if it should instead be its own issue.

We are unsure what to put in the various fields for our two deprecations-then-removals, Removal of navigateEvent.transitionWhile() and Removal of navigateEVent.scroll(). They are both deprecated in 105 and removed in 108. The relevant fields seem to be:

All of this seems related to the question of how we want the Roadmap to look. Ideally we'd show up under the deprecated sections from 105-107 (or just in 105??), and then under the removed section in 108, and then not show up. I have no idea how to accomplish that. With our current choices the features show up once, under 108, as Deprecated (but not Removed).

jpmedley commented 2 years ago

This is a good place to put this. We need to review the whole way that Chrome Status handles these. We hav some design work to do and we need information like this to do it.

I can address some of your comments about relevant fields.

Le me know if you have any questions.

jpmedley commented 2 years ago

Why were you uncertain that 'Feature deprecation' was the proper feature type. I can't propose an improvement if I don't know what it was that threw you off.

domenic commented 2 years ago

Why were you uncertain that 'Feature deprecation' was the proper feature type. I can't propose an improvement if I don't know what it was that threw you off.

A couple of reasons:

jpmedley commented 2 years ago

We need to change 'Feature deprecation' to 'Feature deprecation and removal'. This field controls fields and stages you see in the tool.

jpmedley commented 2 years ago

As I said earlier, we have some significant work to do around deprecations and removals. In the meantime, we're working on some stopgap measures we hope will help. I'll keep you posted.