GoogleChrome / chromium-dashboard

Chrome Status Dashboard
https://www.chromestatus.com
Apache License 2.0
635 stars 363 forks source link

Releases Page Shows Shipping Milestone as an Origin Trial #1535

Closed jpmedley closed 2 years ago

jpmedley commented 2 years ago

Thank you for letting us know that something needs to be fixed. This page is for recording bugs on Chrome Status (https://www.chromestatus.com). If you need to report a problem with Chrome or Chromium, please use crbug (http://crbug.com/new). Thank you.

Describe the bug The features/schedule/ page shows features in a release milestone as being in an origin trial. This is indicated by a puzzle-piece icon as shown in the image below.

image

A look at the underlying feature shows that it is not in an origin trial for the column that it's in.

image

Since the feature on which this problem was found is likely to change, I've recreated the problem in staging (same feature on the release page).

To Reproduce Steps to reproduce the behavior:

  1. On any feature add values to the origin trial milestones.
  2. Add a shipping milestone that is past the origin trial end milestone.
  3. Change the 'Process stage' field to 'Origin Trial'.

Expected behavior The item as listed on the Releases page should not show an origin trial icon.

jrobbins commented 2 years ago

I think the way to fix this should be to launch the /upcoming page. It uses headings to indicate what kind of launch is happening for each feature in each milestone. If you visit https://cr-status-staging.appspot.com/upcoming, you will see your test feature in m95 without the puzzle piece icon, and if you scroll back to m91 it is there with the icon.

jpmedley commented 2 years ago

Makes sense. When is that launching?

jrobbins commented 2 years ago

I have one change in mind that I will work on today. After that, I think it could be ready to launch.

jpmedley commented 2 years ago

Fixed by redesign.