Consolidate the constants on the frontend and the backend

jrobbins commented 2 years ago

Is your feature request related to a problem? Please describe. We have a new search API that can accept "field operator value" search terms, however the values of enums would need to be specified as numbers, which would make no sense to users.

Describe the solution you'd like On the server side:

[x] When parsing a query term on an enum field, check if the value is a string that is one of the enum choices. If so, convert it to the appropriate integer. If it is not one of the enum choices, treat that as an error.

On the client side:

[ ] Change chromedash-feature-filter.py to use form-field-specs.js and form-field-enums.js instead of defining QUERIABLE_FIELDS.
[x] When the field type is 'select' use an sl-select widget to offer the user choices of values to query
[x] When the user is filtering on a enum field, generate a query term like field_name="enum value string"

KyleJu commented 1 year ago

For the task, Change chromedash-feature-filter.py to use form-field-specs.js and form-field-enums.js instead of defining QUERIABLE_FIELDS, we need to consolidate the constants on the frontend and the backend. Plan to take a stab at it Q1 next year

jrobbins commented 1 week ago

I changed the title of this issue to reflect the remaining work.

GoogleChrome / chromium-dashboard

Consolidate the constants on the frontend and the backend #2344