search

GoogleChrome / chromium-dashboard

Chrome Status Dashboard
https://www.chromestatus.com
Apache License 2.0
644 stars 375 forks source link

Need a way to request an API Owners review directly in our new UI #2713

Open jrobbins opened 1 year ago

jrobbins commented 1 year ago

Is your feature request related to a problem? Please describe. The ChromeStatus app parses messages posted to blink-dev and detects new intent threads. However, that process is not perfect. There are cases where a feature owner posts an intent to blink-dev, but does not follow the expected format closely enough for our code to detect. We could handle these cases in the old approvals dialog box by entering a vote of "Review requested". The new UI does not offer that option or a "Request review" button for API Owners gates.

Describe the solution you'd like Replace the current logic that shows either the actions or the "Request review" button with new logic that can show both to site admins and reviewers. Or, maybe it should be spelled out as "Request review of existing intent thread" to clarify that it is different than what a feature owner is supposed to do.

jrobbins commented 1 year ago

The work-around for now is for any reviewer or site admin to vote "Review started". That makes the gate appear on the reviewers' dashboard. However, that same person cannot then change their vote to "Approved" because then there would be nothing to make it appear on the dashboard. If they want to approve an I2S, they need to vote last, as LGTM3.

jstenback commented 1 year ago

In the cases where we don't detect the intent thread and trigger the review request in the tool though another mechanism we can be left w/o the link to the actual intent thread. Should we build in entering that link into the UI at the same time the review is started manually in the tool, or marked as approved so we don't let a feature stay in that partially incomplete state?