GoogleChrome / chromium-dashboard

Chrome Status Dashboard
https://www.chromestatus.com
Apache License 2.0
641 stars 370 forks source link

Fix showEnterprise on enterprise list page. #4146

Closed jrobbins closed 3 months ago

jrobbins commented 3 months ago

The enterprise feature list page was just showing regular features rather than enterprise features.

The code path is a little complicated, but basically whenever a query is set for the chromedash-feature-table, and that query mentions feature_type, then showEnterprise should be set to true, and the query should be set.

However, those properties had attribute: false, so the values passed to them via attributes was not being set. That cause the enterprise feature list to show all features rather than sending any query string to the server, and it did not ask the server to include enterprise features.