search

GoogleChrome / chromium-dashboard

Chrome Status Dashboard
https://www.chromestatus.com
Apache License 2.0
639 stars 366 forks source link

Rename -alias-epub-foo to -epub-foo #445

Open phistuck opened 7 years ago

phistuck commented 7 years ago

Like https://github.com/GoogleChrome/chromium-dashboard/issues/277, -epub properties also have -alias prefixes and should be cleaned up.

jpmedley commented 3 years ago

There are still 9 of them.

punitkcse commented 3 years ago

I would like to take this up can you please provide me more details of how to move ahead

Apocalypse96 commented 3 months ago

hey @phistuck I would love to solve this issue

phistuck commented 3 months ago

I am not a developer of this repository really, but from a quick search, I think this file is responsible for those things - https://github.com/GoogleChrome/chromium-dashboard/blob/main/api/metricsdata.py It seems like https://github.com/GoogleChrome/chromium-dashboard/issues/277 got regressed again as well I imagine it would make sense to simply replace "alias-webkit" and "alias-epub" with "webkit" and "epub", respectively (do not simply remove any "alias-" prefix as it might exclude some a future property that happens to start with "alias", but vendor prefixes like webkit and epub must be the first word, hence it is safe to replace as I noted) While you are there, you might want to de-duplicate as well, see - image

Apocalypse96 commented 3 months ago

I am not a developer of this repository really, but from a quick search, I think this file is responsible for those things - https://github.com/GoogleChrome/chromium-dashboard/blob/main/api/metricsdata.py It seems like #277 got regressed again as well I imagine it would make sense to simply replace "alias-webkit" and "alias-epub" with "webkit" and "epub", respectively (do not simply remove any "alias-" prefix as it might exclude some a future property that happens to start with "alias", but vendor prefixes like webkit and epub must be the first word, hence it is safe to replace as I noted) While you are there, you might want to de-duplicate as well, see - image

Thank you so much, but then who is responsible to assign me this issue , or should I just solve the issue and raise a pr??

phistuck commented 3 months ago

After 7 years, it is pretty safe to say no one is looking at it except you ;) You can just try to resolve it and create a pull request, yep