GoogleChrome / developer.chrome.com

The frontend, backend, and content source code for developer.chrome.com
https://developer.chrome.com
Other
1.67k stars 1.58k forks source link

When using extensions that use sidebar panels with content set with `sidebarPane.setExpression` an error is thrown. #1060

Closed emilianionascu closed 11 months ago

emilianionascu commented 3 years ago

Describe the bug When using extensions that use sidebar panels with content set with sidebarPane.setExpression an error is thrown.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'any extension that uses setExpression, e.g. https://chrome.google.com/webstore/detail/knockoutjs-context-debugg/oddcpmchholgcjgjdnfjmildmlielhof'
  2. Click on 'Add to Chrome'
  3. Load the dev tools with Ctrl + Shift + I
  4. Load the extension dev tools by hitting Ctrl + Shift + I
  5. See the error in the console.

Expected behavior Extensions should still work even after the v92 upgrade. It worked until v91.

Screenshots image

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

robdodson commented 3 years ago

@emilianionascu is this related to any of our documentation? This repo is only for docs work. If you've found a bug in Chrome it should be filed at crbug.com

emilianionascu commented 3 years ago

@robdodson I'm not sure. It could be that the API changed and we're supposed to use setExpression differently. That is a documentation issue. It could be that the API itself has a bug and then it's not a documentation issue.

initplatform commented 3 years ago

I believe I've hit this too with my extension: https://chrome.google.com/webstore/detail/sb-angular-inspector/lapcbklolihkkijaemmlbkpibgghhioh?hl=en

I thought it might be related to manifest 3, so I upgraded.

Still seem to be having an issue with setExpression.

robdodson commented 3 years ago

OK, tentatively assigning to @awfuchs to take a look

dstmarthe commented 11 months ago

Thanks for raising this. We’re moving to a new platform and so we’ll address this over there. I’ve moved the issue to our new tracker and you can see it at: https://issuetracker.google.com/issues/312784415