GoogleChrome / developer.chrome.com

The frontend, backend, and content source code for developer.chrome.com
https://developer.chrome.com
Other
1.67k stars 1.58k forks source link

mv3 sidepanel awareness #7905

Closed KnIfER closed 8 months ago

KnIfER commented 11 months ago

Describe the bug My extension is using the same page for popup mode, normal tab mode, and side panel mode.

The problem is that when I use the following manifest :

"side_panel": {
        "default_path": "file.html?sidepanel=true"
    },

   "action": {
      "default_popup": "file.html?popup=true"
   },

browser complains :

Side panel file path must exist.

where the 'file.html' does exit, it just contains url parameters . without it, how can the extension page know it's opened in side-panel mode ?

Expected behavior either allow url parameters or provide method/property of is_side_panel

Desktop (please complete the following information):

dstmarthe commented 8 months ago

This tracker is for issues with the content at developer.chrome.com, please raise Chromium issues at: https://issues.chromium.org/issues?q=is:open