fixed: focusing steps run both on showModal() and show() call

GoogleChrome / dialog-polyfill

Polyfill for the HTML dialog element

BSD 3-Clause "New" or "Revised" License

2.45k stars 245 forks source link

fixed: focusing steps run both on showModal() and show() call #100

Closed ffuubarbuzz closed 8 years ago

ffuubarbuzz commented 8 years ago

resolves #33

Garbee commented 8 years ago

LGTM

samthor commented 8 years ago

This will cause focus to be triggered every time .show() is called, which I don't think matches the spec. It should instead only focus when first made visible.

samthor commented 8 years ago

See #101.

ffuubarbuzz commented 8 years ago

You are right, thanks