GoogleChrome / dialog-polyfill

Polyfill for the HTML dialog element
BSD 3-Clause "New" or "Revised" License
2.45k stars 245 forks source link

Prioritise AMD module definition #104

Closed merih closed 8 years ago

merih commented 8 years ago

In environments like electron, module['exports'] could also be available, when the website code is using AMD. Previous module definition code was preventing dialog polyfill from being defined as an AMD module in electron since it was cheking CJS module availability first, this PR prioritises AMD definition.

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


merih commented 8 years ago

I signed it!

googlebot commented 8 years ago

CLAs look good, thanks!

googlebot commented 8 years ago

CLAs look good, thanks!

samthor commented 8 years ago

LGTM