GoogleChrome / dialog-polyfill

Polyfill for the HTML dialog element
BSD 3-Clause "New" or "Revised" License
2.45k stars 245 forks source link

Not working on iOS (both iOS Chrome and iOS Safari) #118

Closed iancrew closed 7 years ago

iancrew commented 7 years ago

I'm using the current version of dialog-polyfill with Material Design Lite 1.2.1. On iOS 10.1.1, in both Safari and Chrome, it's not possible to tap into an input field in a dialog, nor is it possible to tap on any of the buttons in a dialog.

I've put a code snippet up illustrating this on StackOverflow

(Really hoping this is user error, and not a bug, as it's currently blocking progress!)

samthor commented 7 years ago

Hey there, I did up a quick demo with your code (it wasn't a simple repro case - but I tried to comment/fix your bugs as much as possible).

http://codepen.io/samthor/pen/yVaQyq

It works fine on on my iPhone and in the Simulator.

samthor commented 7 years ago

Can you try out the version I've just pushed to HEAD? I've been more aggressive in trying to ensure the _dialog_overlay is removed (the proxy for the "top layer" overlay which prevents access to things behind it).

(This is presuming you're not including dialog within another stacking context, i.e., something with its own z-index or position: relative etc - it's described in the README how this is unsupported - although that shouldn't cause this issue).

iancrew commented 7 years ago

Thanks Sam! Trying it right now.

Cheers,

Ian

On Nov 16, 2016, at 3:45 PM, Sam Thorogood notifications@github.com wrote:

Can you try out the version I've just pushed to HEAD? I've been more aggressive in trying to ensure the _dialog_overlay is removed (the proxy for the "top layer" overlay which prevents access to things behind it).

(This is presuming you're not including dialog within another stacking context, i.e., something with its own z-index or position: relative etc - it's described in the README how this is unsupported - although that shouldn't cause this issue).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GoogleChrome/dialog-polyfill/issues/118#issuecomment-261109562, or mute the thread https://github.com/notifications/unsubscribe-auth/AB7BmmvOTs7_yBZNL8pO6p6SODkWvGZDks5q-5WIgaJpZM4KxzSU.


Ian Crew

IST-Architecture, Platforms and Integration (API) Earl Warren Hall, Second Floor University of California, Berkeley

samthor commented 7 years ago

I'll take another look tomorrow, but if it doesn't work, please let me know if the <div class="_dialog_overlay"> is still on your page, and its z-index. If it's above the dialog, with a higher z-index, that's a problem (but a quick description of that would be great).

iancrew commented 7 years ago

Thanks again Sam! I think we’re in business, with the https://github.com/GoogleChrome/dialog-polyfill/commit/a412b0aa909faecf789b6c9cfffc6d196dd9d282 commit of dialog-polyfill.

It turns out that there were two errors that were biting me:

1) I had the dialog-polyfill.css file listed before the https://code.getmdl.io/1.2.1/material.min.css. Switching those around seemed to make the majority of the difference.

2) I was missing a

in my html. (blush!)

With those two fixes in place, things seem to be working great.

I really appreciate all the help!

Cheers,

Ian

On Nov 16, 2016, at 3:52 PM, Sam Thorogood notifications@github.com wrote:

I'll take another look tomorrow, but if it doesn't work, please let me know if the

is still on your page, and its z-index. If it's above the dialog, with a higher z-index, that's a problem (but a quick description of that would be great).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GoogleChrome/dialog-polyfill/issues/118#issuecomment-261111003, or mute the thread https://github.com/notifications/unsubscribe-auth/AB7BmnEuuRrcKKnbNlPCnMYja-9BNlFEks5q-5dbgaJpZM4KxzSU.


Ian Crew

IST-Architecture, Platforms and Integration (API) Earl Warren Hall, Second Floor University of California, Berkeley