search

GoogleChrome / dialog-polyfill

Polyfill for the HTML dialog element
BSD 3-Clause "New" or "Revised" License
2.45k stars 245 forks source link

Escape doesn't close dialog #157

Closed jhpratt closed 6 years ago

jhpratt commented 6 years ago

Easily replicable in Firefox on the example page.

gs-akhan commented 6 years ago

@Admin, Are you accepting PR for this ?

samthor commented 6 years ago

If you'd like to contribute a patch, we'd like to accept it :)

On 20 Jan. 2018 21:08, "Azharuddin" notifications@github.com wrote:

@admin, Are you accepting PR for this ?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/GoogleChrome/dialog-polyfill/issues/157#issuecomment-359160644, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHRkAQTNKe4P1oYeIrFh4J2lDxwe11Xks5tMbsCgaJpZM4Qf4yA .

gs-akhan commented 6 years ago

I don;t think there is an issue with ESC key.

The escape doesn't work for dialog and it is correct because dialog doesn't have backdrop and user is allowed to focus on other elements. We cannot close the dialog when someone hits ESC.

However for Modal where we have backdrop. The ESC closes it on both FF & Chrome.

Thanks

samthor commented 6 years ago

Thanks for the update. I'll close this issue.