Purpose of the .fixed class

GoogleChrome / dialog-polyfill

Polyfill for the HTML dialog element

BSD 3-Clause "New" or "Revised" License

2.45k stars 245 forks source link

Purpose of the .fixed class #170

Closed xfra35 closed 4 years ago

xfra35 commented 6 years ago

There's a .fixed class defined in dialog-polyfill.css, but it doesn't seem to be used anywhere in the library.

Is this class defined on purpose or is it just a remnant of some previous code?

samthor commented 6 years ago

It's left over from some experiment. The <dialog> technically loads in the viewport when you open it (so on a large page, you can scroll up/down and the dialog won't follow you), but honestly that's quite odd.

Maybe this is sort of related to what we should be doing for old IE support, just having an 'old IE/fixed/simple' class: #159

samthor commented 4 years ago

I've added some guidance on this in the README.