GoogleChrome / dialog-polyfill

Polyfill for the HTML dialog element
BSD 3-Clause "New" or "Revised" License
2.45k stars 245 forks source link

Don't override defaultPrevented in handleKey #175

Closed leinaDBA closed 4 years ago

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
leinaDBA commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

I signed it

samthor commented 5 years ago

Thanks for this, but we can't find your CLA signature under your GitHub username. Can you sign it again?

leinaDBA commented 5 years ago

I go to click again & it says:

Contributor License Agreements Google Individual Contributor License Agreement Below is the contact information we have for your Google Individual CLA. The information you provide below, along with your IP address and a timestamp, will be maintained in accordance with Google's privacy policy.

It looks like you've already signed this CLA. If you'd like to edit your contact information, you may do so below.

Date Signed Nov 13, 2018 06:42 PST Email(s) Learn more about managing email addresses for your account.

leinadba@gmail.com leinadbeel@hotmail.com Name * Daniel Ben Avraham GitHub Username If you change your GitHub Username, please update it here too.

samthor commented 4 years ago

I just made this change myself. Thanks for the PR.

FWIW I looked up your Gmail account and we could have accepted your code; but that record doesn't seem to be attached to your GitHub account. Just something to keep in mind for future contributions to Google projects 👍