Closed wowczarek closed 5 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
) and we'll verify it.
ℹ️ Googlers: Go here for more info.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
) and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
Thanks!
Some existing browser implementations of
HTMLDialogelement
already handle theonclose
property. Sinceonclose
defines a single handler, it is extremely useful when reusing dialogs, as opposed toaddEventListener()
, where there is no ready or easy or clean way to clear any existing handlers. Withonclose
, a dialog element can be used as a template and just haveonclose
assigned to whatever handler if and when necessary.