Adhere to `event.defaultPrevented` on form submit events

runarberg commented 5 years ago

Fixes: #191

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

runarberg commented 5 years ago

@googlebot I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

samthor commented 5 years ago

Thank you!

runarberg commented 5 years ago

Is there an ETA for when this gets published in a new version?

samthor commented 5 years ago

Hi, probably when I get time next week after Chrome Dev Summit.

On Fri, 1 Nov 2019 at 08:35, Rúnar Berg Baugsson Sigríðarson < notifications@github.com> wrote:

Is there an ETA for when this gets published in a new version?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/GoogleChrome/dialog-polyfill/pull/192?email_source=notifications&email_token=AAA5DECQ6L5OS72GPFZXEOTQRNFQHA5CNFSM4JGAV6I2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECZKJIA#issuecomment-548578464, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA5DEGL5UMA6M73MQWNKHTQRNFQHANCNFSM4JGAV6IQ .

runarberg commented 4 years ago

Just seeing if you plan on releasing a patch soon?

GoogleChrome / dialog-polyfill