Closed qurben closed 3 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
CLAs look good, thanks!
ℹ️ Googlers: Go here for more info.
So I confess I haven't been paying that much attention to the other issue. I appreciate that there is a problem, but I am confused. The dist esm file has this line in it:
export default dialogPolyfill;
That's literally the default export. It seems like this PR just adds another variable called dialogPolyfill
of the core type. But we don't export that; we export a default.
I missed a line when applying my changes, sorry!
The created variable should be exported as the default. This tells Typescript that a value is exported an not a type.
Thanks. I'm learning about TS types vs variables too from this. I'll release an update soon.
Fixes GoogleChrome/dialog-polyfill#204
Should not have an impact on the cjs types.