GoogleChrome / dialog-polyfill

Polyfill for the HTML dialog element
BSD 3-Clause "New" or "Revised" License
2.45k stars 245 forks source link

Don’t expose polyfill to global when in CJS/AMD #94

Closed niksy closed 8 years ago

niksy commented 8 years ago

Closes #93.

Also, I’ve removed forceRegisterDialog and registerDialog methods since they’re already defined on dialogPolyfill object which is exported to window. I suppose that’s OK?

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


niksy commented 8 years ago

I signed it!

googlebot commented 8 years ago

CLAs look good, thanks!

googlebot commented 8 years ago

CLAs look good, thanks!

samthor commented 8 years ago

LGTM