search

GoogleChrome / lighthouse-ci

Automate running Lighthouse for every commit, viewing the changes, and preventing regressions
Apache License 2.0
6.43k stars 647 forks source link

Run on page with interactions / flows #383

Open michellbrito opened 4 years ago

michellbrito commented 4 years ago

Hi

I'm wondering if lighthouse can perform audits on a modal that needs to be clicked for it to be open. Currently If I click on the modal and run the audit since the page gets refresh the modal goes away and the audit doesn't include the elements from that modal.

Thank you!

patrickhulce commented 4 years ago

Thanks for filing @michellbrito! The only way to do this right now is by exposing the modal through a client-side routing URL i.e. /path/to/page#modal-open or something similar.

It's a frequently requested Lighthouse core feature (https://github.com/GoogleChrome/lighthouse/issues/3837 / https://github.com/GoogleChrome/lighthouse/issues/1769) when Lighthouse CI receives a Lighthouse update with this functionality we'll be sure to document it here too :)

lebreRafael commented 1 year ago

Since this is now available on Lighthouse, are there any plans to support it on lighthouse-ci?

adamraine commented 1 year ago

Since this is a very old issue here are the docs on user flows: https://github.com/GoogleChrome/lighthouse/blob/main/docs/user-flows.md Previous discussion on the topic https://github.com/GoogleChrome/lighthouse-ci/issues/729

Full user flow support would definitely be nice to have although this will require a large UX investment. Individual timespan/snapshot reports should be much easier to support since the JSON result is the same structure as navigation mode.