search

GoogleChrome / lighthouse-ci

Automate running Lighthouse for every commit, viewing the changes, and preventing regressions
Apache License 2.0
6.41k stars 646 forks source link

Quick start guide should explain how to pass LHCI_GITHUB_APP_TOKEN to Lighthouse CI GitHub App #521

Closed janosh closed 3 years ago

janosh commented 3 years ago

The docs for setting up the Lighthouse CI GitHub App could be improved.

It took way too long to find out on a third-party site how to pass the LHCI_GITHUB_APP_TOKEN to lhci in GitHub actions. Adding the final two lines in this snippet to the quick start guide at https://github.com/apps/lighthouse-ci would be immensely helpful.

- run: lhci autorun
  env:
    LHCI_GITHUB_APP_TOKEN: ${{ secrets.LHCI_GITHUB_APP_TOKEN }}
patrickhulce commented 3 years ago

Thanks @janosh! I updated the GitHub app quickstart to use our latest GitHub Actions quick start example instead of travis 👍