search

GoogleChrome / lighthouse-ci

Automate running Lighthouse for every commit, viewing the changes, and preventing regressions
Apache License 2.0
6.41k stars 644 forks source link

Latest docker server patrickhulce/lhci-server breaks UI on page refresh #884

Closed mihalikv closed 1 year ago

mihalikv commented 1 year ago

Describe the bug If you go to some project or other non-homepage URL, and hit refresh(F5), the whole site is broken.

To Reproduce Steps to reproduce the behavior:

  1. Go to '/app/projects/${project}/dashboard'
  2. Hit refresh
  3. Site will be broken

Expected behavior The site should work also after a refresh

Logs/Screenshots https://user-images.githubusercontent.com/10236315/223979316-6506967d-e56a-4d24-ab5d-f90e055a8960.mp4

Environment (please complete the following information):

Additional context I test it also with patrickhulce/lhci-server:0.10.0 and it works fine even after refresh.

Archanium commented 1 year ago

I've fixed this one for my self using the dockerfile you can see here: https://github.com/Archanium/docker-images/blob/master/lhci/Dockerfile I've also pushed it to https://hub.docker.com/r/archanium/lhci-server

sandrodesouza commented 1 year ago

https://github.com/GoogleChrome/lighthouse-ci/issues/893#issuecomment-1499270991

paulirish commented 1 year ago

Thanks for reporting!

This is fixed in https://github.com/GoogleChrome/lighthouse-ci/pull/879 Which was released in lhci v0.11.1 A matching new release of the patrickhulce/lhci-server docker image also shipped yesterday.

And FYI we have a new release of lhci coming which bumps the LH version used to 10.x. You can watch #891 for updates on that.