search

GoogleChrome / lighthouse-ci

Automate running Lighthouse for every commit, viewing the changes, and preventing regressions
Apache License 2.0
6.41k stars 644 forks source link

fix(docker): added extra environment variable to lhci-client Dockerfile for puppeteer executable #916

Closed Eliasvdb closed 1 year ago

Eliasvdb commented 1 year ago

A while ago I submitted https://github.com/GoogleChrome/lighthouse-ci/pull/736 to fix issues with using puppeteer in the lhci-client docker image.

In the meantime, puppeteer seems broken again in the latest docker image version. After some investigation, this is most likely a problem occurring after the puppeteer upgrade from v13 to v19. In more recent versions, puppeteer keeps a cache of browser versions it downloads. Since in this image we skip the chromium download for puppeteer, because a chrome version is already included for the ligthouse tests, we should specify where our chrome version is located. This was quick fixable by passing the env var in the docker conatiner run command, but should in my opinion be defined in the Dockerfile.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.