search

GoogleChrome / lighthouse-ci

Automate running Lighthouse for every commit, viewing the changes, and preventing regressions
Apache License 2.0
6.33k stars 633 forks source link

Bug localStorage in Lighthouse Report Diff Tool #935

Closed torresgol10 closed 10 months ago

torresgol10 commented 10 months ago

The bug is on the web: https://googlechrome.github.io/lighthouse-ci/difftool/

If you upload a large file, for example 1.4MB, the application stays with the fixed animation, in the console, it gives a failure, which says that the maximum size has been accessed in the localStorage.

Browser, Chrome Desktop latest version.

I was looking at the code and I can make a PR, adding a try catch in the part where the failure occurs, so you can catch the error, but the application will continue to run.

Thanks.

paulirish commented 10 months ago

Nice! yeah a PR would be great. :)

paulirish commented 10 months ago

fixed by #938