perf: Concurrent Asynchronous Execution: Optimizing Performance with `Promise.all` ✈

GoogleChrome / lighthouse-ci

Automate running Lighthouse for every commit, viewing the changes, and preventing regressions

Apache License 2.0

6.33k stars 633 forks source link

perf: Concurrent Asynchronous Execution: Optimizing Performance with `Promise.all` ✈ #995

Closed sanjaiyan-dev closed 2 weeks ago

sanjaiyan-dev commented 6 months ago

Hello,

This pull request introduces a performance improvement by executing asynchronous tasks concurrently using Promise.all. The enhancement aims to optimize the effective utilization of hardware resources.

This PR draws inspiration from a similar one (though not identical) in the Deno runtime, where the execution time was reduced by 85% through concurrent processing. For reference, please see: https://github.com/denoland/deno_std/pull/3363.

Thank you for considering these enhancements.

connorjclark commented 2 weeks ago

Sorry but I don't think these changes are worth the churn. Also they may be problematic, sending so many requests at once to external services like GitHub may be too bursty and hit API limits.