budget should count inline resources

GoogleChrome / lighthouse

Automated auditing, performance metrics, and best practices for the web.

https://developer.chrome.com/docs/lighthouse/overview/

Apache License 2.0

28.37k stars 9.37k forks source link

budget should count inline resources #10586

Open connorjclark opened 4 years ago

connorjclark commented 4 years ago

scripts, css, data fonts, etc. A big inline JS script should count towards the Document and the JS budget.

@khempenius does this seem fine to you?

khempenius commented 4 years ago

Yep, I agree that they should count towards both.

Not the question asked per se, but I think that ideally, along with this change, a breakdown of inlined document content by resource type should be exposed to the user. Otherwise, this information is a bit of a pain for a user to gather on their own.

connorjclark commented 4 years ago

next steps:

count inline resources twice: as Document and as Script/CSS/etc.
punt on breaking down resource types of Document in the report (we have UI questions)
we should look into timing budgets for script evaluation too.