Open mattzeunert opened 3 years ago
Heh. Rip the slow implementation that the new slow one is better than.
But yeah this is still observable. Some budgets make sense. In ImageElements we only applied budgets to the protocol work that was particularly bad.. EG I can imagine the captureSnapshot call is fairly quick but the work afterwards isnt.
We can prioritize which nodes we start investigating... cap at some limit, and set a time budget for the pricy parts. (it feels pretty likely that it's fetchFailingNodeSourceRules
but we'd need some more instrumentation to be sure.
@mattzeunert interested in taking this?
see also #11289 #12065 #7274 #9818
We can prioritize which nodes we start investigating... cap at some limit, and set a time budget for the pricy parts. (it feels pretty likely that it's fetchFailingNodeSourceRules but we'd need some more instrumentation to be sure.
We are doing this, see the top of the gatherer file. We just got some expectations wrong about how long each individual action might take. We should swap to a time cap instead of a "# of actions" cap.
@mattzeunert interested in taking this?
No, not right now.
Running Lighthouse on this URL takes a long time: https://www.gucci.com/us/en/pr/women/handbags/shoulder-bags-for-women/bucket-bags-for-women/jackie-1961-small-shoulder-bag-p-636706HUHHG8565
It seems to be caused by the font size gatherer.
I tried running with
--verbose
to see more details.It looks like the
getMatchedStylesForNode
calls are slow sometimes.Could this be sped up somehow? Or have a budget like the image elements gatherer?