GoogleChrome / lighthouse

Automated auditing, performance metrics, and best practices for the web.
https://developer.chrome.com/docs/lighthouse/overview/
Apache License 2.0
28.1k stars 9.33k forks source link

add new UIString for non-composited-animations due to custom properties #14521

Open brendankenny opened 1 year ago

brendankenny commented 1 year ago

Animating custom properties appear to always end up non-composited (at least outside of CSS painting), and get lumped with all the other non-composited CSS properties found in the trace (don't be surprised like me and note that this happens regardless of what the property is animating, e.g. animating translate through fixed values is usually composited, animating --yheight in translate: 0 var(--yheight) will not be).

For example, you could end up with Unsupported CSS Property: --swing-y in non-composited-animations alongside other failed animations giving Unsupported CSS Property: color (or even in a list from the same animation, Unsupported CSS Properties: --swing-y, color.

It would be nice to separate the custom properties and give a little more context. You can probably figure out what it's referring to pretty easily, but it is a little weird to have these two types of things put together.

One solution we've discussed was splitting out any unsupported properties (probably here) beginning with -- and then giving a new failure string for them, e.g. Custom CSS properties cannot be animated on the compositor: --swing-y

These custom properties are Chromium-based browsers only right now, so low priority for this fix.

DeRaowl commented 1 year ago

Hi @brendankenny I have gone through the issue and I can work on it. Can you assign this to me?

varunseth578 commented 1 year ago

i would like to contribute to this issue. or need any other help.

ZainGulbaz commented 1 year ago

@adamraine Can you please assign this issue to me?

with-shrey commented 9 months ago

@brendankenny can you please assign this to me ?