search

GoogleChrome / lighthouse

Automated auditing, performance metrics, and best practices for the web.
https://developer.chrome.com/docs/lighthouse/overview/
Apache License 2.0
28.23k stars 9.35k forks source link

Audit bug [?] Site Does Not Use Resources That Delay First Paint #1504

Closed amedina closed 7 years ago

amedina commented 7 years ago

The result of the audit is showing an undefined access error instead of the links blocking first page rendering.

screen shot 2017-01-20 at 11 50 55 am
amedina commented 7 years ago

Here is the full report (JSON)

ebidel commented 7 years ago

URL is https://m.olx.com.ar/

@amedina, I wasn't able to repro this using the latest extension:

screen shot 2017-01-20 at 12 23 05 pm

Is it reliable to reproduce?

cc @patrickhulce

patrickhulce commented 7 years ago

hmmm, yeah @ebidel you fixed this awhile ago I thought. Doesn't seem possible on master at least as the only use of indexOf is guarded for undefinedness.

ebidel commented 7 years ago

11 days ago seems like forever ago :) @amedina, This should be fixed in master and in the next release.

https://github.com/GoogleChrome/lighthouse/commit/929d0a81b0d2788b4c82fcff85527f7a79271536

amedina commented 7 years ago

@ebidel, @patrickhulce You are correct; it works perfect on the extension; I observed the issue when I ran it via the CLI, which I have at version 1.4.1. I did an npm update and the version did not change.

ebidel commented 7 years ago

We're planning a new 1.5 release early next week. npm update should pick up the fix after that.

amedina commented 7 years ago

Thanks!