GoogleChrome / lighthouse

Automated auditing, performance metrics, and best practices for the web.
https://developer.chrome.com/docs/lighthouse/overview/
Apache License 2.0
28.19k stars 9.34k forks source link

Don't suppress all errors in optimized images #15484

Open adamraine opened 11 months ago

adamraine commented 11 months ago

Similar to https://github.com/GoogleChrome/lighthouse/pull/15259, we shouldn't suppress all errors, only the "No resource with given identifier found" errors for when the response gets evicted from cache.

This occurs on the following CDP command: https://github.com/GoogleChrome/lighthouse/blob/dac27623ce691fc87204cf38569b4710704bc726/core/gather/gatherers/dobetterweb/optimized-images.js#L91

Found in sentry and also in sentry

Also causes another error in sentry indirectly

paulirish commented 11 months ago

Check out the calls of EvictContent: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/inspector/network_resources_data.cc;l=120;drc=49a952fddb576b129aab7c6b333513b0d9e22adf

It gets called for a bunch of reasons.. And if its evicted, then we'll get the above error message ("No resource with given identifier found"): https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/inspector/inspector_network_agent.cc;l=2245-2253;drc=52e7293bdc0f9f4958876d2eaa7f24f7b88a85e4


One reason we're probably getting this is because by default we max out at 100MB for all resources and 10MB for an individual resource: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/inspector/inspector_network_agent.cc;l=124-125;drc=49a952fddb576b129aab7c6b333513b0d9e22adf

If those were higher we probably would see this less.