search

GoogleChrome / lighthouse

Automated auditing, performance metrics, and best practices for the web.
https://developer.chrome.com/docs/lighthouse/overview/
Apache License 2.0
28.05k stars 9.32k forks source link

clients(lr): always apply category filter/ignoreStatusCode #15838

Closed connorjclark closed 4 months ago

connorjclark commented 4 months ago

There's no reason to not apply these when given a explicit config. This allows the others options of a LR request to compose nicely with the internal "use this config" option.

connorjclark commented 4 months ago

on second thought it seems LR always pass some value for categoryIDs here, despite what the type suggests. Which means LR would need to change how it treats an "empty" array (user did not specify anything) to pass undefined instead of all the categories explicitly (well...4 of them), in order to convey to runLighthouseInLR that nothing was specified. That's not a very safe change to make, so not worth for this internal thing.