search

GoogleChrome / lighthouse

Automated auditing, performance metrics, and best practices for the web.
https://developer.chrome.com/docs/lighthouse/overview/
Apache License 2.0
28.05k stars 9.32k forks source link

core(render-blocking): use trace engine as the source of truth #15839

Closed adamraine closed 3 months ago

adamraine commented 4 months ago

https://github.com/GoogleChrome/lighthouse/issues/2065

https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5250877

Uses the new RenderBlocking insight in the trace engine to find render blocking requests. Also eliminates the need for the TagsBlockingFirstPaint artifact.

connorjclark commented 4 months ago

Did you assess the differences between our logic in TabsBlockingFirstPaint and using the blink signal? ref https://github.com/GoogleChrome/lighthouse/issues/2065#issuecomment-780995113

adamraine commented 4 months ago

I verified that our expectations in dbw smoke test are the same but did not inspect the raw data.

adamraine commented 4 months ago

Looks like this is working, but we will need to wait for M123 to be stable before we think about shipping this