GoogleChrome / lighthouse

Automated auditing, performance metrics, and best practices for the web.
https://developer.chrome.com/docs/lighthouse/overview/
Apache License 2.0
28.05k stars 9.32k forks source link

core: fix regression in internal chrome error messages #15853

Closed connorjclark closed 4 months ago

connorjclark commented 4 months ago

We have accidentally unused error definitions in lh-error.js (the ones with pattern:). We are supposed to check every sendCommand for an error response and via fromProtocolMessage create a better error message. But this was never replicated in the new gatherer's connection module.

You can easily confirm this by duplicating the Tracing.start command in trace.js.