Closed adamraine closed 4 months ago
devtools_skip_typecheck=true is the only way to really speed up DT builds according to this doc: https://chromium.googlesource.com/devtools/devtools-frontend/+/main/docs/get_the_code.md#standalone-checkout-build
devtools_skip_typecheck=true
Validating types is still valuable for each patch, so leaving it on in CI.
One annoying problem is that local builds will spit out a bunch of [WARNING] Unrecognized target environment "es2022" warnings for some reason :/
[WARNING] Unrecognized target environment "es2022"
This PR also removes the use_goma=true and requisite user email check because it has been removed from non-windows builds as of recently.
use_goma=true
devtools_skip_typecheck=trueis the only way to really speed up DT builds according to this doc: https://chromium.googlesource.com/devtools/devtools-frontend/+/main/docs/get_the_code.md#standalone-checkout-buildValidating types is still valuable for each patch, so leaving it on in CI.
One annoying problem is that local builds will spit out a bunch of
[WARNING] Unrecognized target environment "es2022"warnings for some reason :/This PR also removes the
use_goma=trueand requisite user email check because it has been removed from non-windows builds as of recently.