search

GoogleChrome / lighthouse

Automated auditing, performance metrics, and best practices for the web.
https://developer.chrome.com/docs/lighthouse/overview/
Apache License 2.0
28.27k stars 9.35k forks source link

tests(devtools): use `is_debug = true` for local builds #15860

Closed adamraine closed 7 months ago

adamraine commented 7 months ago

According to simon (in chat):

Release build do some additional bundling with rollup and minification with terser and are the slowest.

Let's use debug builds for local debugging. In theory we could also do debug builds for CI, but I would prefer to play it safe and verify everything we do is compatible with release builds in CI.

Additionally, doesn't look like devtools_dcheck_always_on does anything anymore. I couldn't find any usages of this build arg and all the dcheck stuff from this CL is gone.