search

GoogleChrome / lighthouse

Automated auditing, performance metrics, and best practices for the web.
https://developer.chrome.com/docs/lighthouse/overview/
Apache License 2.0
28.05k stars 9.32k forks source link

core: remove `no-unload-listeners` audit #15874

Closed adamraine closed 3 months ago

adamraine commented 3 months ago

Closes https://github.com/GoogleChrome/lighthouse/issues/15766

Also removes GlobalListeners artifact.

brendankenny commented 3 months ago

Is this clean up or fixing something pressing? I know long term the audit doesn't fit into a trace-first world, but removing (default) support for unload listeners on most sites doesn't start until Q3, with full removal by Q1 2025, so warning devs to not use unload listeners still seems like a good goal until sometime in that time.

Could this live as-is for another few quarters and not hurt anything?

adamraine commented 3 months ago

so warning devs to not use unload listeners still seems like a good goal until sometime in that time.

We already warn about this in deprecations AND bfcache. IMO it doesn't need it's own audit anymore.

brendankenny commented 3 months ago

Ah, didn't realize (or just forgot) it was in deprecations. Nice!