GoogleChrome / lighthouse

Automated auditing, performance metrics, and best practices for the web.
https://developer.chrome.com/docs/lighthouse/overview/
Apache License 2.0
28.03k stars 9.32k forks source link

core: remove `duplicate-id-active` #15900

Closed adamraine closed 3 months ago

adamraine commented 3 months ago

duplicate-id-active is deprecated in axe-core (See https://github.com/dequelabs/axe-core/issues/3892):

This rule was created to catch a problem with Dragon Naturally Speaking, where if active controls like buttons shared an ID, Dragon could activate the first element with that ID, even if you asked it to activate the second. Axe reports this as a serious issue. After some testing we've discovered this problem no longer exists. So for this rule we'll deprecate and tag it the same way we're doing for duplicate-id.

Our internal review of accessibility audits does seem to contradict this a bit by saying it is a good signal. However, there were some concerns in that spreadsheet about how useful it was on page load, and since axe doesn't seem to be supporting it anymore I think it's safe to remove.

Part of https://github.com/GoogleChrome/lighthouse/issues/15440