Closed adamraine closed 6 months ago
This fixes the weird package-test errors we have been getting recently.
Some change in node 18.20.0 appears to have fixed a bug that our .npmignore was relying on.
Without a leading slash, entries in .npmignore should refer to any file/folder with that name in the directory structure. Before 18.20.0 this wasn't happening for some reason.
I attempted to correct as many entires in our .npmignore as I could, and verified that the contents by diffing [old .npmignore & node 18.19] against [new .npmignore & 18.20]
Ref https://github.com/nodejs/node/issues/52382
This fixes the weird package-test errors we have been getting recently.
Some change in node 18.20.0 appears to have fixed a bug that our .npmignore was relying on.
Without a leading slash, entries in .npmignore should refer to any file/folder with that name in the directory structure. Before 18.20.0 this wasn't happening for some reason.
I attempted to correct as many entires in our .npmignore as I could, and verified that the contents by diffing [old .npmignore & node 18.19] against [new .npmignore & 18.20]
Ref https://github.com/nodejs/node/issues/52382