search

GoogleChrome / lighthouse

Automated auditing, performance metrics, and best practices for the web.
https://developer.chrome.com/docs/lighthouse/overview/
Apache License 2.0
28.26k stars 9.35k forks source link

core(lantern): correct overlapping tasks in CPU nodes #15938

Closed adamraine closed 5 months ago

adamraine commented 5 months ago

I was investigating the weird CI failures in https://github.com/GoogleChrome/lighthouse/pull/15839. Long story short the CI failure is caused by the same issue in https://github.com/GoogleChrome/lighthouse/issues/15896 where RunTask events can sometimes be overlapping.

We fixed this when calculating observed TBT in https://github.com/GoogleChrome/lighthouse/pull/15921, but we did not correct the overlapping tasks in Lantern.

I suspect we may need another PR to address this in main-thread-tasks.js as well...