search

GoogleChrome / lighthouse

Automated auditing, performance metrics, and best practices for the web.
https://developer.chrome.com/docs/lighthouse/overview/
Apache License 2.0
28.02k stars 9.32k forks source link

docs: remove await from chrome.kill() #15982

Closed ajuni880 closed 1 month ago

ajuni880 commented 2 months ago

Hi,

Summary

Have removed the await keyoword for chrome.kill method because based on it's types it's a void method.

https://github.com/GoogleChrome/chrome-launcher/blob/main/src/chrome-launcher.ts#L51

google-cla[bot] commented 2 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.