search

GoogleChrome / lighthouse

Automated auditing, performance metrics, and best practices for the web.
https://developer.chrome.com/docs/lighthouse/overview/
Apache License 2.0
28.01k stars 9.31k forks source link

core(types): add missing fields to `Result.Category` and `NodeDetails` #16006

Closed angad-sethi closed 1 month ago

angad-sethi commented 1 month ago

This PR fixes #15799. Summary

  1. The property supportedModes has been added to Result.Category since it is being emitted as a part of the generated results.
  2. The property explanation has been added to Artifacts.NodeDetails since it is being set in axe-audit.js (line 79).

    I've added them in as optional types, please let me know if that is incorrect. Cheers!

Related Issues/PRs

Related Issue - #15799

google-cla[bot] commented 1 month ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.