GoogleChrome / proxy-polyfill

Proxy object polyfill
Apache License 2.0
1.14k stars 175 forks source link

fix: Always use correct prototype for ordinary objects #67

Closed ExE-Boss closed 4 years ago

ExE-Boss commented 4 years ago

Addresses part of https://github.com/GoogleChrome/proxy-polyfill/issues/14.

This makes it so that Proxies of ordinary objects are always created with target.[[Prototype]] as their prototype.

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

ExE-Boss commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot commented 4 years ago

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

samthor commented 4 years ago

So I feel like, after some reading, is that this is really just adding improved older browser support. I can't find a practical way to test the outcomes in a modern browser (and I've not updated the tests to delete the things we're checking).

I have some tweaks I'll make afterwards but I'm happy.