search

GoogleChrome / related-website-sets

Apache License 2.0
445 stars 568 forks source link

Create VIE-Related-Websites #322

Open ARSGeek opened 8 months ago

ARSGeek commented 8 months ago

This is new territory for me. So I'm flying blind a bit. A client's website has an 3rd-party i-frame form on it that is being blocked by Google Chrome on iOS only. My research brought me to the Google Developers Related Website Set. Which brought me here. I think I'm doing this the right way. I just want to clear up the issue with the client's website.

google-cla[bot] commented 8 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

cfredric commented 8 months ago

Hi @ARSGeek, the biggest issue with this PR is that it creates a brand new file, instead of modifying the existing related_website_sets.JSON file. Please follow the instructions here in order to get your set ready for submission.

However, based on your description, I'm not sure that RWS is a viable solution to your problem.

Firstly, RWS is not supported in Chrome on iOS (for technical reasons). So, even if this set were submitted as-is, it wouldn't change the behavior you're seeing.

Secondly, your client will need to do some work to prepare their sites (assuming they control both the top-level site and the iframe form's site) for being in an RWS, namely they need to satisfy the .well-known requirements. But considering you say the iframe is 3rd-party, it doesn't sound like the client controls both of those sites, ultimately.

ARSGeek commented 8 months ago

@cfredric Thank you for your reply. This may not be even the issue since the 3rd-party form works fine on all Desktop versions and well as android. It is only iPhones that don't show the form. I may put this on hold and investigate with the 3rd-party vendor.

github-actions[bot] commented 8 months ago

Looks like you've passed all of the checks!

cfredric commented 1 week ago

It looks like you haven’t updated this PR in a while. Your PR will close in 14 days if there aren’t any updates or comments on this PR.