GoogleChrome / rendertron

A Headless Chrome rendering solution
https://render-tron.appspot.com/
Apache License 2.0
5.93k stars 794 forks source link

Missing `Googlebot` keyword in middleware botUserAgents list. #229

Closed mskasal closed 5 years ago

mskasal commented 5 years ago

These days I am very interested in polymer's pwa starter kit which using prpl-server which using rendertron. So, when I try using Google's fetch as Google service for testing SEO, I got blank pages.

screen shot 2018-10-11 at 14 39 57

I fixed that with adding userAgentPattern option in prpl-server's cli.ts (not configurable from CLI !!, have to fix hard coded)

I wonder if there is a reason for not including Googlebot in this list? Thanks.

samuelli commented 5 years ago

Hi,

Yes, this is intentional. Please review https://medium.com/dev-channel/polymer-2-and-googlebot-2ad50c5727dd.

Thanks, Sam