GoogleChrome / rendertron

A Headless Chrome rendering solution
https://render-tron.appspot.com/
Apache License 2.0
5.94k stars 808 forks source link

Question about scaling and race conditions #690

Closed rudolfbyker closed 2 years ago

rudolfbyker commented 3 years ago

Is running multiple Rendertron containers (e.g. AWS ECS) with a shared filesystem (e.g. AWS EFS) cache vulnerable to race conditions? Or is this supported?

gravi2 commented 3 years ago

@rudolfbyker I am having similar setup and so far have not seen issues based on some internal testing only. This is yet to go to production, so can't comment much. I would expect the EFS to be slower but have not benchmarked. Do share your findings too.

rudolfbyker commented 3 years ago

Thanks! I'm also Considering using the far gate "bind mount", which is faster, but ephemeral. But then the same question about race conditions needs to be answered. I will report back later if and when I know whether my setup works. :)

On Sat, 15 May 2021, 01:34 Ravi Gidwani, @.***> wrote:

@rudolfbyker https://github.com/rudolfbyker I am having similar setup and so far have not seen issues based on some internal issues only. This is yet to go to production, so can't comment much. I would expect the EFS to be slower but have not benchmarked. So share your findings.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GoogleChrome/rendertron/issues/690#issuecomment-841551124, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACMPS7Q67CBNTDYIJ5SAGKLTNWXO3ANCNFSM44YYLU6Q .

gravi2 commented 3 years ago

Are you using rendertron on AWS fargate? I did read few articles where people setup puppeteer on AWS fargate and AWS lambda. But was wondering if rendertron performance will be lower on fargate compared to bare EC2 instances.

On Fri, May 14, 2021, 11:55 PM Rudolf Byker @.***> wrote:

Thanks! I'm also Considering using the far gate "bind mount", which is faster, but ephemeral. But then the same question about race conditions needs to be answered. I will report back later if and when I know whether my setup works. :)

On Sat, 15 May 2021, 01:34 Ravi Gidwani, @.***> wrote:

@rudolfbyker https://github.com/rudolfbyker I am having similar setup and so far have not seen issues based on some internal issues only. This is yet to go to production, so can't comment much. I would expect the EFS to be slower but have not benchmarked. So share your findings.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/GoogleChrome/rendertron/issues/690#issuecomment-841551124 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ACMPS7Q67CBNTDYIJ5SAGKLTNWXO3ANCNFSM44YYLU6Q

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/GoogleChrome/rendertron/issues/690#issuecomment-841611751, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJSAUTCWBKICYEI7CM3NFTTNYLHZANCNFSM44YYLU6Q .

rudolfbyker commented 3 years ago

Yes, I'm running Rendertron on AWS ECS with the "Fargate" launch type. Seems to work fine.

On Sat, 15 May 2021 at 09:11, Ravi Gidwani @.***> wrote:

Are you using rendertron on AWS fargate? I did read few articles where people setup puppeteer on AWS fargate and AWS lambda. But was wondering if rendertron performance will be lower on fargate compared to bare EC2 instances.

On Fri, May 14, 2021, 11:55 PM Rudolf Byker @.***> wrote:

Thanks! I'm also Considering using the far gate "bind mount", which is faster, but ephemeral. But then the same question about race conditions needs to be answered. I will report back later if and when I know whether my setup works. :)

On Sat, 15 May 2021, 01:34 Ravi Gidwani, @.***> wrote:

@rudolfbyker https://github.com/rudolfbyker I am having similar setup and so far have not seen issues based on some internal issues only. This is yet to go to production, so can't comment much. I would expect the EFS to be slower but have not benchmarked. So share your findings.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <

https://github.com/GoogleChrome/rendertron/issues/690#issuecomment-841551124

, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ACMPS7Q67CBNTDYIJ5SAGKLTNWXO3ANCNFSM44YYLU6Q

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/GoogleChrome/rendertron/issues/690#issuecomment-841611751 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAJSAUTCWBKICYEI7CM3NFTTNYLHZANCNFSM44YYLU6Q

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GoogleChrome/rendertron/issues/690#issuecomment-841613672, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACMPS7SWTNHC25UC7IS5UYDTNYNDTANCNFSM44YYLU6Q .

AVGP commented 2 years ago

In general, as we're deprecating the project, you should look into alternative approaches to rendering on the web.